Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tcgc] consider scope when find service of a client #1338

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

tadelesh
Copy link
Member

@tadelesh tadelesh commented Aug 9, 2024

fix: #1326

@tadelesh tadelesh changed the base branch from main to release/august-2024 August 9, 2024 07:40
@azure-sdk
Copy link
Collaborator

azure-sdk commented Aug 9, 2024

All changed packages have been documented.

  • @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - fix ✏️

consider scope when find service of a client

@azure-tools/typespec-client-generator-core - feature ✏️

Add @hasJsonConverter for csharp only to indicate if JSON converter is needed

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious about what would VS code plugin report (where no emitter in scope)?

@iscai-msft iscai-msft merged commit f924176 into release/august-2024 Aug 14, 2024
22 checks passed
@iscai-msft iscai-msft deleted the fix-decorator-scope branch August 14, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: tcgc, unexpected warning on operationGroup within client with scope
4 participants