Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] support int as string encoding #1258

Merged
merged 9 commits into from
Aug 1, 2024
Merged

[tcgc] support int as string encoding #1258

merged 9 commits into from
Aug 1, 2024
+138 −1

Conversation

iscai-msft
Copy link
Contributor

@iscai-msft iscai-msft commented Jul 29, 2024 •
edited
Loading

fixes #1177 , #1178

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 29, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - feature ✏️

add support for encoding an int as a string

lmazuel
lmazuel approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'm reading is that we would consider that @encode(string) is the same thing as @encode("string"), which makes sense for me, and simplify TCGC integration, so I'm good with it.

@iscai-msft iscai-msft added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit 8f005c0 Aug 1, 2024
20 of 22 checks passed
@iscai-msft iscai-msft deleted the allow_int_string branch August 1, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encode int as string TCGC Author doc
5 participants
@iscai-msft @azure-sdk @timotheeguerin @lmazuel @weidongxu-microsoft