Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tcgc] add xml usage and fix generic decorator issue #1204

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

tadelesh
Copy link
Member

for xml support

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 19, 2024

All changed packages have been documented.

  • @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - fix ✏️

have @clientName work for operation groups as well

@azure-tools/typespec-client-generator-core - feature ✏️

add xml usage and change enumvalue arg representation in generic decorators

@tadelesh tadelesh changed the title [tcgc] add xml usage [tcgc] add xml usage and fix generic decorator issue Jul 19, 2024
@iscai-msft iscai-msft merged commit c521e6f into release/july-2024 Jul 19, 2024
20 of 22 checks passed
@iscai-msft iscai-msft deleted the xml_usage branch July 19, 2024 17:44
@@ -603,4 +603,6 @@ export enum UsageFlags {
Error = 1 << 7,
// Set when model is used in conjunction with an application/json content type.
Json = 1 << 8,
// Set when model is used in conjunction with an application/xml content type.
Xml = 1 << 8,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 1 << 9?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this as well - I will open a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants