Migrate azure core library to use generated decorator signature #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
requested review from
bterlson,
markcowl and
allenjzhang
as code owners
microsoft-github-policy-service
bot
added
the
lib:azure-core
|
All changed packages have been documented.
Show changes
|
chrisradek
approved these changes
Jul 18, 2024
|
You can try these changes here
|
iscai-msft
pushed a commit
to iscai-msft/typespec-azure
that referenced
this pull request
Jul 18, 2024
…e#1198) Step to having all our libraries use tspd to generate the signatures and make sure they are in sync. There is quite a lot of times we expected the wrong type which would cause a crash. This fix a few to get the more precise type in the TypeSpec if it was going to crash originally. Otherwise expand the type in the TS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step to having all our libraries use tspd to generate the signatures and make sure they are in sync.
There is quite a lot of times we expected the wrong type which would cause a crash. This fix a few to get the more precise type in the TypeSpec if it was going to crash originally. Otherwise expand the type in the TS