add @override to override default method signature generation
#1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All changed packages have been documented.
Show changes
|
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/1148/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/1148/ |
packages/typespec-client-generator-core/test/decorators.test.ts
Outdated
Show resolved
Hide resolved
added 2 commits
July 12, 2024 14:44
iscai-msft
requested review from
lmazuel,
m-nash,
srnagar,
joheredi,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
tadelesh
reviewed
Jul 16, 2024
|
another concern is what weidong mentioned in the issue: #1054 (comment) |
added 6 commits
July 16, 2024 10:40
|
You can try these changes here
|
added 2 commits
July 19, 2024 13:52
…verride_client_method
tadelesh
reviewed
Jul 23, 2024
added 5 commits
August 1, 2024 13:51
…verride_client_method
…verride_client_method
iscai-msft
changed the title
@overrideClientMethod@methodSignature to override default generation
tadelesh
approved these changes
Aug 5, 2024
weidongxu-microsoft
approved these changes
Aug 5, 2024
srnagar
reviewed
Aug 5, 2024
docs/libraries/typespec-client-generator-core/reference/decorators.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Srikanta <[email protected]>
iscai-msft
changed the title
@methodSignature to override default generation@override to override default method signature generation
added 2 commits
August 5, 2024 17:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1054