Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace direct OpenAPI extension reference to add x-ms-azure-resource with internal decorator #1123

Merged
merged 9 commits into from
Jul 10, 2024
Merged

Replace direct OpenAPI extension reference to add x-ms-azure-resource with internal decorator #1123

merged 9 commits into from
Jul 10, 2024

Conversation

allenjzhang
Copy link
Member

Removed direct reference to OpenAPI extension x-ms-azure-resource in ARM library and replaced with @Azure.ResourceManager.Private.azureResourceBase decorator. It is only used internally on base resource types. autorest emitter has been updated to check the decorator and still emit x-ms-azure-resource extension in swagger.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 3, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-autorest
  • ✅ @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-autorest - feature ✏️

Removed direct reference to OpenAPI extension x-ms-azure-resource in ARM library and replaced with @Azure.ResourceManager.Private.azureResourceBase decorator. It is only used internally on base resource types. autorest emitter has been updated to check the decorator and still emit x-ms-azure-resource extension in swagger.

@azure-tools/typespec-azure-resource-manager - feature ✏️

Removed direct reference to OpenAPI extension x-ms-azure-resource in ARM library and replaced with @Azure.ResourceManager.Private.azureResourceBase decorator. It is only used internally on base resource types. autorest emitter has been updated to check the decorator and still emit x-ms-azure-resource extension in swagger.

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/1123/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/1123/

@allenjzhang allenjzhang added this pull request to the merge queue Jul 10, 2024
Merged via the queue into Azure:main with commit 8a10bb1 Jul 10, 2024
21 checks passed
@allenjzhang allenjzhang deleted the azhang_RemoveAzureResource branch July 10, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisradek chrisradek chrisradek left review comments

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@allenjzhang @azure-sdk @timotheeguerin @chrisradek