Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow @armCommonDefinition decorator to be used on enums and unions #1116

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Allow @armCommonDefinition decorator to be used on enums and unions #1116

merged 7 commits into from
Jul 11, 2024

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jul 2, 2024 •
edited
Loading

fix #995

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library label Jul 2, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 2, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-autorest
  • ✅ @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - feature ✏️

Link CommonTypes enums and unions to the swagger common types

@azure-tools/typespec-autorest - feature ✏️

Resolve Arm Common Definitions for enums and unions as well

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/1116/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/1116/

@timotheeguerin timotheeguerin added this pull request to the merge queue Jul 11, 2024
Merged via the queue into Azure:main with commit fcebc28 Jul 11, 2024
21 checks passed
@timotheeguerin timotheeguerin deleted the arm-common-def-enum-union branch July 11, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allenjzhang allenjzhang allenjzhang approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

Assignees
No one assigned
Labels
lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable @armCommonDefinition to be applied to enum and union
3 participants
@timotheeguerin @azure-sdk @allenjzhang