Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArmResourcePatch templates and incorporate common-types updates Fix #859 #1081

Merged
merged 17 commits into from
Jul 15, 2024

Conversation

markcowl
Copy link
Member

No description provided.

@markcowl markcowl changed the title Resource patch Fix ArmResourcePatch templates and incorporate common-types updates Fix #859 Jun 26, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 26, 2024

All changed packages have been documented.

  • @azure-tools/typespec-autorest
  • @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-autorest - fix ✏️

Fix patch models for common-types

@azure-tools/typespec-azure-resource-manager - fix ✏️

Fix ArmResourcePatch templates and incorporate common-types updates

@azure-sdk
Copy link
Collaborator

@markcowl markcowl force-pushed the resource-patch branch 2 times, most recently from 48007ca to 0f44cc2 Compare June 27, 2024 17:25
@markcowl
Copy link
Member Author

The typespec-next PR for this is here: Azure/azure-rest-api-specs#29617

was able to make these changes with a search and replace and then a tsp format:

search: ^    azure-resource-provider-folder: "resource-manager"
replace: 
    azure-resource-provider-folder: "resource-manager"
    emit-common-types-schema: "reference-only"
in: specification/**/tspconfig.yaml

search: ArmResourcePatch(Sync|Async)(\s*)<([\s\r\n]*)(\w+)([\s\r\n]*),([\s\r\n]*)(\w+)
replace:ArmCustomPatch$1$2<$3$4$5,$6Azure.ResourceManager.Foundations.ResourceUpdateModel<$4, $7>
in specification/**/*.tsp

pnpm-lock.yaml Outdated Show resolved Hide resolved
core Outdated Show resolved Hide resolved
@markcowl markcowl force-pushed the resource-patch branch 2 times, most recently from 6b81e6f to 0fe620e Compare July 11, 2024 22:45
@markcowl markcowl added this pull request to the merge queue Jul 15, 2024
Merged via the queue into Azure:main with commit 685d6ef Jul 15, 2024
21 checks passed
@markcowl markcowl deleted the resource-patch branch July 15, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants