Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] add example model in tcgc #1076

Merged
merged 50 commits into from
Jul 24, 2024
Merged

[tcgc] add example model in tcgc #1076

merged 50 commits into from
Jul 24, 2024

Conversation

tadelesh
Copy link
Member

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 25, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-autorest-canonical
  • ✅ @azure-tools/typespec-autorest
  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-client-generator-core - breaking ✏️

refactor tcgc build-in types, please refer pr's description for details and migration guides

@azure-tools/typespec-client-generator-core - fix ✏️

have @clientName work for operation groups as well

@azure-tools/typespec-client-generator-core - fix ✏️

Fix @clientName conflict validation that operation defined within an interface

@azure-tools/typespec-client-generator-core - feature ✏️

add example types support

@azure-tools/typespec-autorest - internal ✏️

create tcgc context change to async

@azure-tools/typespec-autorest-canonical - internal ✏️

adopt tcgc breaking

@azure-tools/typespec-client-generator-core - feature ✏️

add xml usage and change enumvalue arg representation in generic decorators

@tadelesh tadelesh added the breaking-change A change that might cause specs or code to break label Jun 25, 2024
@tadelesh
Copy link
Member Author

this pr contains breaking change: createSdkContext change from sync to async.

iscai-msft
iscai-msft reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, thank you so much for your hard work @tadelesh

packages/typespec-autorest/src/emit.ts Show resolved Hide resolved
packages/typespec-client-generator-core/src/example.ts Outdated Show resolved Hide resolved
packages/typespec-client-generator-core/src/example.ts Outdated Show resolved Hide resolved
packages/typespec-client-generator-core/src/example.ts Outdated Show resolved Hide resolved
packages/typespec-client-generator-core/src/example.ts Outdated Show resolved Hide resolved
packages/typespec-client-generator-core/src/public-utils.ts Show resolved Hide resolved
@tadelesh tadelesh changed the base branch from main to release/july-2024 July 17, 2024 06:03
@tadelesh tadelesh merged commit 374c373 into release/july-2024 Jul 24, 2024
20 of 22 checks passed
@tadelesh tadelesh deleted the tcgc_sample branch July 24, 2024 09:33
@ArcturusZhang ArcturusZhang mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang left review comments

@iscai-msft iscai-msft iscai-msft left review comments

@MaryGao MaryGao MaryGao approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@msyyc msyyc msyyc approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
breaking-change A change that might cause specs or code to break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample generation TCGC Implementation
7 participants
@tadelesh @azure-sdk @weidongxu-microsoft @MaryGao @ArcturusZhang @iscai-msft @msyyc