Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We have any in SdkBuiltinKinds for the built-in type unknown in typespec, why not unknown? #874

Closed
ArcturusZhang opened this issue May 21, 2024 · 2 comments · Fixed by #1463
Closed

We have any in SdkBuiltinKinds for the built-in type unknown in typespec, why not unknown? #874

ArcturusZhang opened this issue May 21, 2024 · 2 comments · Fixed by #1463
Assignees
@ArcturusZhang
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@ArcturusZhang
Copy link
Member

It is not a good practice that we change a name for a builtin type. Is it because the kind unknown is ambiguous from the type with a name of unknown and the case where there is an invalid kind which we do not know?
@markcowl markcowl added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label May 29, 2024
@tadelesh tadelesh added the bug Something isn't working label Jun 11, 2024
@iscai-msft
Copy link
Contributor

Yeah that was the original thinking, and because it aligned more closely with what we got from m4. Happy to change this though, it will just be a breaking change that will have to be driven across languages

@iscai-msft iscai-msft added this to the [2024] September milestone Aug 7, 2024
@tadelesh
Copy link
Member

proposal: change any to unknown

@ArcturusZhang ArcturusZhang mentioned this issue Sep 3, 2024
Merged
@markcowl markcowl removed this from the [2024] September milestone Sep 12, 2024
ArcturusZhang added a commit that referenced this issue Sep 14, 2024
@ArcturusZhang
Polish some API names in TCGC (#1463)
94e5fe7 
Fixes #874
Fixes #933
Fixes #1462
Fixes #1466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArcturusZhang ArcturusZhang

Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Polish some API names in TCGC ArcturusZhang/typespec-azure
4 participants
@markcowl @tadelesh @ArcturusZhang @iscai-msft