Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tcgc] tcgc could not handle version propagation correctly #802

Closed
tadelesh opened this issue May 8, 2024 · 0 comments · Fixed by #805
Closed

[tcgc] tcgc could not handle version propagation correctly #802

tadelesh opened this issue May 8, 2024 · 0 comments · Fixed by #805
Assignees
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@tadelesh
Copy link
Member

tadelesh commented May 8, 2024

if there is not versioning decorator, we should use parent versioning info.
for example: operation use interface/namespace versioning, parameter use operation versioning, model property use model versioning
this causes wrong apiVersions info for some types in current result.

impacted cadl-ranch test: https://github.com/Azure/cadl-ranch/tree/main/packages/cadl-ranch-specs/http/versioning/added

@tadelesh tadelesh added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label May 8, 2024
@tadelesh tadelesh self-assigned this May 8, 2024
github-merge-queue bot pushed a commit that referenced this issue May 9, 2024
fixes #802

---------

Co-authored-by: iscai-msft <[email protected]>
Co-authored-by: tadelesh <[email protected]>
tadelesh added a commit that referenced this issue May 10, 2024
fixes #802

---------

Co-authored-by: iscai-msft <[email protected]>
Co-authored-by: tadelesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant