Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typespec-autorest emitter could not handle discriminated model with multi inherence layer #458

Closed
tadelesh opened this issue Mar 21, 2024 · 3 comments · Fixed by #512
Closed

typespec-autorest emitter could not handle discriminated model with multi inherence layer #458

tadelesh opened this issue Mar 21, 2024 · 3 comments · Fixed by #512
Labels
bug Something isn't working
Milestone
[2024] May

Comments

@tadelesh
Copy link
Member

See example.
@markcowl markcowl modified the milestone: Backlog Mar 22, 2024
@markcowl
Copy link
Member

This is specifically out of scope, given that this project is only fixing critical bugs

@markcowl markcowl closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@tadelesh
Copy link
Member Author

It is used in one of the green field service though they have already abandoned to use TypeSpec. I believe we need to give a solution for it.

@tadelesh tadelesh reopened this Mar 25, 2024
@markcowl markcowl assigned markcowl and unassigned markcowl Mar 25, 2024
@markcowl markcowl added the bug Something isn't working label Mar 25, 2024
@markcowl markcowl added this to the [2024] May milestone Mar 25, 2024
@timotheeguerin timotheeguerin mentioned this issue Mar 25, 2024
Merged
@timotheeguerin
Copy link
Member

timotheeguerin commented Mar 25, 2024 •
edited
Loading

This works with openapi3 and is understood by the getDiscriminatorUnion compiler helper so this is just a bug in autorest emitter which doesn't make use of this.
Fixed in #512

timotheeguerin added a commit that referenced this issue Apr 1, 2024
@timotheeguerin
Fix: Intermediate discriminated type (#512)
9cb95e8 
fix #458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
[2024] May
Development

Successfully merging a pull request may close this issue.

Fix: Intermediate discriminated type timotheeguerin/typespec-azure
3 participants
@timotheeguerin @markcowl @tadelesh