Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support @clientName for union/enum variant name #309

Closed
tadelesh opened this issue Feb 26, 2024 · 1 comment · Fixed by #314
Closed

Support @clientName for union/enum variant name #309

tadelesh opened this issue Feb 26, 2024 · 1 comment · Fixed by #314
Assignees
@tadelesh
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@tadelesh
Copy link
Member

tadelesh commented Feb 26, 2024 •
edited
Loading

related code:

typespec-azure/packages/typespec-client-generator-core/src/types.ts

Line 599 in 00f500c

name: typeof name === "string" ? name : `${member.value}`,

playground

The name for union/enum variant should honor @clientName decorator.
@tadelesh tadelesh added bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library getAllModels labels Feb 26, 2024
@tadelesh tadelesh self-assigned this Feb 26, 2024
@tadelesh tadelesh changed the title Support @clientName for union variant name Support @clientName for union/enum variant name Feb 26, 2024
@tadelesh tadelesh mentioned this issue Feb 26, 2024
Merged
tadelesh added a commit that referenced this issue Feb 28, 2024
@tadelesh @iscai-msft
support @clientName for extensible enum variant (#314)
560be86 
fix: #309

add a fix for operation group path does not adopt `@clientName`

---------

Co-authored-by: iscai-msft <[email protected]>
@weidongxu-microsoft
Copy link
Member

cadl-ranch Azure/cadl-ranch#525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadelesh tadelesh

Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support @clientName for extensible enum variant Azure/typespec-azure
2 participants
@tadelesh @weidongxu-microsoft