Remove the tspnamespace added to some of the types
#1073
Assignees
Labels
lib:tcgc
Issues for @azure-tools/typespec-client-generator-core library
Comments
ArcturusZhang
added
the
lib:tcgc
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 26, 2024
…l, union and array types (#1075) Fixes #1073 Per offline discussion, `crossLanguageDefinitionId` is actually a much better candidate of telling people the originate of this type, therefore this should solve all of our requirement and we no longer need a `tspNamespace` anymore. --------- Co-authored-by: Chenjie Shi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We previously add the
tspNamespaceto identify exactly where this type was defined in the typespec file. But actually we are mislooking that there is already a property on model and enum to show that - thecrossLanguageDefinitionId.The downstream generator could use this value to know which typespec file the type is defined, which nullifies the purpose we add
tspNamespace.We might need to remove the
tspNamespaceproperty.The text was updated successfully, but these errors were encountered: