fixing missing Retry-After in DeleteLroResponse (#410)

Co-authored-by: Mark Cowlishaw <[email protected]>
Azure · Mar 14, 2024 · ac16317 · ac16317
1 parent b10f51e
commit ac16317
Show file tree

Hide file tree

Showing 24 changed files with 256 additions and 236 deletions.
diff --git a/.chronus/changes/azhang_fixRetryAfter-2024-2-12-22-49-3.md b/.chronus/changes/azhang_fixRetryAfter-2024-2-12-22-49-3.md
@@ -0,0 +1,7 @@
+---
+changeKind: fix
+packages:
+  - "@azure-tools/typespec-azure-resource-manager"
+---
+
+Fixing ArmDeleteLroResponse missing Retry-After header
diff --git a/docs/libraries/azure-resource-manager/reference/data-types.md b/docs/libraries/azure-resource-manager/reference/data-types.md
@@ -44,21 +44,21 @@ model Azure.ResourceManager.ArmAcceptedLroResponse<Description, LroHeaders>
 ### `ArmAcceptedResponse` {#Azure.ResourceManager.ArmAcceptedResponse}
 
 ```typespec
-model Azure.ResourceManager.ArmAcceptedResponse<Message>
+model Azure.ResourceManager.ArmAcceptedResponse<Message, ExtraHeaders>
 ```
 
 #### Template Parameters
 
-| Name    | Description                                                                        |
-| ------- | ---------------------------------------------------------------------------------- |
-| Message | The description of the response status (defaults to `Resource operation accepted`) |
+| Name         | Description                                                                        |
+| ------------ | ---------------------------------------------------------------------------------- |
+| Message      | The description of the response status (defaults to `Resource operation accepted`) |
+| ExtraHeaders | Additional headers in the response. Default includes Retry-After header            |
 
 #### Properties
 
-| Name        | Type    | Description                                                                                              |
-| ----------- | ------- | -------------------------------------------------------------------------------------------------------- |
-| statusCode  | `202`   | The status code.                                                                                         |
-| retryAfter? | `int32` | The Retry-After header can indicate how long the client should wait before polling the operation status. |
+| Name       | Type  | Description      |
+| ---------- | ----- | ---------------- |
+| statusCode | `202` | The status code. |
 
 ### `ArmAsyncOperationHeader` {#Azure.ResourceManager.ArmAsyncOperationHeader}
 
@@ -110,22 +110,22 @@ model Azure.ResourceManager.ArmCombinedLroHeaders<StatusMonitor, FinalResult, Po
 The Azure Resource Manager 201 response for a resource
 
 ```typespec
-model Azure.ResourceManager.ArmCreatedResponse<ResponseBody>
+model Azure.ResourceManager.ArmCreatedResponse<ResponseBody, ExtraHeaders>
 ```
 
 #### Template Parameters
 
-| Name         | Description                       |
-| ------------ | --------------------------------- |
-| ResponseBody | The contents of the response body |
+| Name         | Description                                                             |
+| ------------ | ----------------------------------------------------------------------- |
+| ResponseBody | The contents of the response body                                       |
+| ExtraHeaders | Additional headers in the response. Default includes Retry-After header |
 
 #### Properties
 
-| Name        | Type           | Description                                                                                              |
-| ----------- | -------------- | -------------------------------------------------------------------------------------------------------- |
-| statusCode  | `201`          | The status code.                                                                                         |
-| retryAfter? | `int32`        | The Retry-After header can indicate how long the client should wait before polling the operation status. |
-| body        | `ResponseBody` | The body type of the operation request or response.                                                      |
+| Name       | Type           | Description                                         |
+| ---------- | -------------- | --------------------------------------------------- |
+| statusCode | `201`          | The status code.                                    |
+| body       | `ResponseBody` | The body type of the operation request or response. |
 
 ### `ArmDeleteAcceptedLroResponse` {#Azure.ResourceManager.ArmDeleteAcceptedLroResponse}
 

diff --git a/...est/output/azure/resource-manager/arm-library/@azure-tools/typespec-autorest/openapi.json b/...est/output/azure/resource-manager/arm-library/@azure-tools/typespec-autorest/openapi.json
@@ -267,14 +267,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },
@@ -516,14 +516,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },
@@ -866,14 +866,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },
@@ -1333,14 +1333,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },
@@ -1561,14 +1561,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },

diff --git a/...rm-scenarios/nobody-action/@azure-tools/typespec-autorest/2021-10-01-preview/openapi.json b/...rm-scenarios/nobody-action/@azure-tools/typespec-autorest/2021-10-01-preview/openapi.json
@@ -416,14 +416,14 @@
           "202": {
             "description": "Resource operation accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },
@@ -473,14 +473,14 @@
           "202": {
             "description": "Resource operation accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },

diff --git a/...est/output/azure/resource-manager/codesigning/@azure-tools/typespec-autorest/openapi.json b/...est/output/azure/resource-manager/codesigning/@azure-tools/typespec-autorest/openapi.json
@@ -340,14 +340,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },

diff --git a/...es/test/output/azure/resource-manager/contoso/@azure-tools/typespec-autorest/openapi.json b/...es/test/output/azure/resource-manager/contoso/@azure-tools/typespec-autorest/openapi.json
@@ -337,14 +337,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },

diff --git a/...ut/azure/resource-manager/csharpattributetest/@azure-tools/typespec-autorest/openapi.json b/...ut/azure/resource-manager/csharpattributetest/@azure-tools/typespec-autorest/openapi.json
@@ -332,14 +332,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },

diff --git a/.../azure/resource-manager/customer-managed-keys/@azure-tools/typespec-autorest/openapi.json b/.../azure/resource-manager/customer-managed-keys/@azure-tools/typespec-autorest/openapi.json
@@ -330,14 +330,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },

diff --git a/...tput/azure/resource-manager/discriminatortest/@azure-tools/typespec-autorest/openapi.json b/...tput/azure/resource-manager/discriminatortest/@azure-tools/typespec-autorest/openapi.json
@@ -337,14 +337,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },

diff --git a/...resource-manager/dynatrace/@azure-tools/typespec-autorest/2021-06-13-preview/openapi.json b/...resource-manager/dynatrace/@azure-tools/typespec-autorest/2021-06-13-preview/openapi.json
@@ -415,14 +415,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },
@@ -1033,14 +1033,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },

diff --git a/...resource-manager/dynatrace/@azure-tools/typespec-autorest/2022-04-30-preview/openapi.json b/...resource-manager/dynatrace/@azure-tools/typespec-autorest/2022-04-30-preview/openapi.json
@@ -415,14 +415,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },
@@ -1033,14 +1033,14 @@
           "202": {
             "description": "Resource deletion accepted.",
             "headers": {
+              "Location": {
+                "type": "string",
+                "description": "The Location header contains the URL where the status of the long running operation can be checked."
+              },
               "Retry-After": {
                 "type": "integer",
                 "format": "int32",
                 "description": "The Retry-After header can indicate how long the client should wait before polling the operation status."
-              },
-              "Location": {
-                "type": "string",
-                "description": "The Location header contains the URL where the status of the long running operation can be checked."
               }
             }
           },