Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ordering locks to avoid deadlock #676

Merged
merged 1 commit into from
Nov 20, 2024
Merged

bugfix: ordering locks to avoid deadlock #676

merged 1 commit into from
Nov 20, 2024

Conversation

ms-henglu
Copy link
Member

Fixes #672

@ms-henglu ms-henglu requested a review from magodo November 19, 2024 06:57
Copy link
Contributor

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a user error?

@ms-henglu
Copy link
Member Author

Isn't this a user error?

Yes, it could be fixed by the user input. But I think the user might not understand why it's necessary to sort the locked resource IDs.

Copy link
Contributor

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest we change it to be a set if we want to reorder for the users, and mention this in the document.

@ms-henglu
Copy link
Member Author

Maybe not necessary to make it a breaking change, because we only use it in a sorted order.

@ms-henglu ms-henglu merged commit c95c788 into main Nov 20, 2024
10 checks passed
@ms-henglu ms-henglu deleted the issue-672 branch November 20, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: using multiple locks can result in a deadlock
2 participants