-
Notifications
You must be signed in to change notification settings - Fork 77
Integrate azcore #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Integrate azcore #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms-henglu
requested changes
Mar 2, 2022
magodo
commented
Mar 3, 2022
Member
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the underlying transport layer
autorest-gowithazcore. This automatically replaced the underlying auth packagego-azure-helper/hamiltonwithazidentity/msal-go.Notable Changes
There are multiple changes introduced during the integration, which are listed below.
Transport Layer
Auth Layer
msi_endpooint, while the track2 allows users to specify the ID of the managed identity, which is different. Since in most cases,msi_endpointis not needed to specify, so we can leave this feature absent for now.Other feature
metadata_hostcan be used to set a customized metadata host, which can return customized endpoint for authorization or/and responding ARM API.