updates to resolve issue #794 #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run unit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run update |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run unit |
1 similar comment
|
/azp run unit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ATuckwell
force-pushed
the
bug/794/deploy-private-dns-zones
branch
from
4822c83 to
3b7ae45
Compare
|
/azp run unit |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anmolnagpal
pushed a commit
to clouddrove/terraform-azure-landingzone
that referenced
this pull request
Jul 8, 2024
* feat(connectivity): Add option to set allow_non_virtual_wan_traffic in express route gateway. (Azure#914) Co-authored-by: Miltos Tsatsakis <[email protected]> * updates to resolve issue Azure#794 (Azure#919) Co-authored-by: github-actions <[email protected]> * docs: update docs for threat_intelligence_allowlist (Azure#928) * Update wiki-sync.yml * chore(deps): bump github/super-linter from 5 to 6 (Azure#931) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add link to Upgrade guide from v4.2.0 to v5.0.0 (Azure#934) Co-authored-by: Matt White <[email protected]> * Added hub_routing_preference to connectivity advanced configuration (Azure#930) * Policy sync updates (Azure#959) * Update Library Templates (automated) (Azure#966) Co-authored-by: github-actions <[email protected]> * Add remote branch option (Azure#970) * Update Library Templates (automated) (Azure#973) Co-authored-by: github-actions <[email protected]> * Update Library Templates (automated) (Azure#976) Co-authored-by: github-actions <[email protected]> * Remove redundant assignment file (Azure#977) * updating threat intelligence allowlist dynamic block (Azure#953) Co-authored-by: Matt White <[email protected]> * chore(deps): bump azure/powershell from 1 to 2 (Azure#917) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add OpenSFF Scorecard (Azure#987) * chore(deps): bump github/codeql-action from 3.24.9 to 3.25.8 (Azure#990) * chore(deps): bump github.com/hashicorp/go-getter from 1.7.3 to 1.7.4 in /tests/terratest (Azure#986) * feat!: ama (Azure#968) * Fix example uami issue (Azure#1000) * Update Library Templates (automated) (Azure#1001) Co-authored-by: github-actions <[email protected]> * docs: additional v6 upgrade detail (Azure#1002) * Update Library Templates (automated) (Azure#1006) Co-authored-by: github-actions <[email protected]> * docs: update docs with FAQ on roadmap and banner for upcoming breaking changes (Azure#1008) * naming fixed in module --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Mtsa <[email protected]> Co-authored-by: Miltos Tsatsakis <[email protected]> Co-authored-by: Adam Tuckwell <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Jared Holgate <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tobias <[email protected]> Co-authored-by: Matt White <[email protected]> Co-authored-by: QBY-MarkusMaring <[email protected]> Co-authored-by: cae-pr-creator[bot] <126156663+cae-pr-creator[bot]@users.noreply.github.com> Co-authored-by: Daan Toes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR relates to an issue raised in bug #794. The issue is that the managed identity created as part of policy assignment "deploy-private-dns-zones" does not have adequate permissions to add Host A records in the relevant private DNS zone within the connectivity subscription. This change takes the managed identity principal ID and applies Private DNS Zone Contributor rights on the Connectivity management group.
This PR fixes/adds/changes/removes
#794
Breaking Changes
None
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
Local testing performed with PR'd code changes with the desired outcome as below.
The Principal ID (Object ID) of the MI associated to initiative assignment.
Validation of the Object ID of the MI within Entra ID.
Confirmation that the above MI had the required perms at the Connectivity management group.
As part of this Pull Request I have
mainbranch