Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating Private DNS Zone resource ID from dnszones to dnsZones #910

Merged

Conversation

tobiasehlert
Copy link
Contributor

Overview/Summary

Seems that the Resource ID of the Public DNS zone should be written as dnsZones and and dnszones.

We might want to add refactoring feature to resolv renaming of resources to prevent re-creation?

This PR fixes/adds/changes/removes

  1. fix Bug: Private DNS Zone resource ID named dnszones and not dnsZones #909

Breaking Changes

  1. Terraform state resource names are changing due to "key" change

Testing Evidence

N/A

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@matt-FFFFFF
Copy link
Member

Thanks for the PR!

@tobiasehlert
Copy link
Contributor Author

Something more that I need to do with this PR @matt-FFFFFF? There seems to be one GitHub Action that is stuck.

@matt-FFFFFF
Copy link
Member

/azp run unit

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matt-FFFFFF matt-FFFFFF merged commit e6cb214 into Azure:main Mar 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Private DNS Zone resource ID named dnszones and not dnsZones
2 participants