Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library template update automation, and bug fixes #44

Merged
merged 47 commits into from
Mar 6, 2021
Merged

Library template update automation, and bug fixes #44

merged 47 commits into from
Mar 6, 2021

Conversation

krowlandson
Copy link
Contributor

This PR introduces the following updates:

  • Update Unit and E2E test pipelines to use YML templates and dynamic matrix generation.
  • Add custom PS module for Enterprise Scale Library Tools to handle automated library template updates.
  • Add script and GitHub Action to enable automated library template updates from Azure/Enterprise-Scale repository using a CI pipeline.
  • Add offline ProviderApiVersions cache in Enterprise Scale Library Tools to negate the need for Azure credentials.
  • Update Library Templates (automated) using new CI process.
  • Manual remediations to updated library templates to ensure full compatibility with Terraform (needs to be fixed at source to prevent regression).
  • Update Policy Assignments and archetypes to provide parity with WingTip reference Enterprise-Scale foundations.
  • Update Resource definitions in base module to use name field instead of properties.displayName to allow setting a more "human-friendly" displayName on policies and roles.
  • Fix bug where duplicate roles are created at the same scope for policy assignments with managed identity.
  • Add customizable delay between deployment of different resource types to reduce deployment errors due to caching and replication in the Azure API (Improvement to help Fix Cannot create role definition and assign to mgmn group #37).
  • Update root_parent_id validation regex to include support for additional supported characters (Fix root_parent_id validation for Management Group ID #43).

Further work/assessment to planned for subsequent PR to ensure fixes are implement for:

Kevin Rowlandson and others added 30 commits February 9, 2021 20:23
Merge pull request #1 from Azure/main
5112d10 
Merge udpates from upstream
Merge remote-tracking branch 'upstream/main' into main
442b41d
Update CI to use templates and dynamic matrix
c4ded66 
* Use yml templates for shared CI tasks
* Add matrix generator for CI tasks
Merge branch 'main' into main
22277e2
Merge remote-tracking branch 'upstream/main' into main
f2f4452
Create initial PS module for Library Tools
4d05e44
Update ESLT module
cfb2cef
Add script and workflow for CI
ee8de1c
Add working-directory for make
d9bf097
Fix makefile (missing separator)
ef8b81a
Update file permission to allow execute
4a96482
Set parameters values for Invoke-LibraryUpdate.ps1
2bb5eda
Add #!/usr/bin/pwsh to file
836a621
Amend Update Library Templates step
f145b12
Add installation message to CI
64fd984
Add offline ProviderApiVersions cache
d7ee83a
Update branch name on push
5a23fd7
Remove update-library-templates
80c4bcc
Update indentation for pull_request step
d774306
Add quotes to strings in PR step
70d4dea
Add github token for pull_request
02b5eb1
Replace quotes around strings for gh pr
ba40462
Add GitHub Context and PR logic
9813267
Update PR logic
2926498
Add else action for PR logic
7e5de26
Use env.var for az_accounts_minimum_version
6a6c06c
Use OrderedDictionary as base object for classes
3d394eb
@actions-user
Update Library Templates (automated)
8d7e108
Improve logic on CI steps
6694b00
Add github_token for gh api command
daa3ba0
Kevin Rowlandson and others added 13 commits March 3, 2021 21:54
Remove expression syntax from conditions
2ea0ab4
Update logic for removing escaped characters
b5e290c
Rebase patch-library (#5)
8381adf 
* Improve logic on CI steps

* Add github_token for gh api command

* Fetch all history for local repository

* Add escaping to double-quotes in string

* Update CHECK_GIT_STATUS to array

* Update expression in step conditions

* Remove expression syntax from conditions

* Update logic for removing escaped characters
@actions-user
Update Library Templates (automated)
32493df
Refine policies and archetypes
59516dd
Update to use name instead of displayName
6a52f25
Update test deployment
b62bf40
Patch regression in policy
493333c
Fix duplicate roles from mismatched case
25778f6
Add delay between different resource types
62d8bf7
Update root_parent_id validation regex
ba73970
Fix terraform fmt error
6c3debf
Merge pull request #4 from krowlandson/patch-library
6bf7b85 
Update Library Templates (automated)
@krowlandson krowlandson added bug Something isn't working enhancement New feature or request labels Mar 6, 2021
@krowlandson krowlandson requested a review from ljtill March 6, 2021 13:50
@krowlandson krowlandson self-assigned this Mar 6, 2021
@krowlandson krowlandson changed the title Feature policy updates and bug fixes Library template update automation, and bug fixes Mar 6, 2021
@krowlandson krowlandson mentioned this pull request Mar 6, 2021
Closed
@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krowlandson krowlandson marked this pull request as ready for review March 6, 2021 14:12
@krowlandson
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

ljtill
ljtill approved these changes Mar 6, 2021
View reviewed changes
Copy link
Member

@ljtill ljtill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krowlandson krowlandson merged commit d8bd5bf into Azure:main Mar 6, 2021
@krowlandson krowlandson linked an issue Mar 8, 2021 that may be closed by this pull request
Error assigning custom Azure policy to Archetype #45
Closed
@krowlandson krowlandson mentioned this pull request Mar 8, 2021
Closed
@krowlandson krowlandson deleted the feature-policy-updates branch March 12, 2021 09:03
@krowlandson krowlandson mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljtill ljtill ljtill approved these changes

Assignees

@krowlandson krowlandson

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@krowlandson @ljtill @actions-user