Documentation fixes due to missing variable attributes

[jonclyde]

Overview/Summary

Changes to the documentation due to the addition of new variables in the Azure Landing Zone module that were causing terraform to fail at apply stage.

This was the error when following the deploy connectivity resources with custom settings article:

Resolved by adding advanced_vpn_settings as per default values in variables.tf of the module.

This was the error when following the deploy management resources with custom settings article:

Resolved by adding enabled_defender_for_containers with a value of true.

This PR fixes/adds/changes/removes

1. Error for missing "advanced_vpn_settings" variable attribute after following the article for deploy connectivity resources with custom settings and running terraform apply.
2. Error for missing "enable_defender_for_containers" variable attribute after following the article for deploy management resources with custom settings and running terraform apply.
3. Fixes Bug Report #366

Breaking Changes

1. None

Testing Evidence

Apply works for deploying connectivity resources with custom settings:

Apply works for deploying management resources with custom settings:

As part of this Pull Request I have

• Checked for duplicate Pull Requests
• Associated it with relevant issues, for tracking and closure.
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated relevant and associated documentation.
• [N\A] Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

[ghost]

All CLA requirements met.

[krowlandson]

This looks good to me @jonclyde. Thank you for identifying this and raising the PR to fix.

@matt-FFFFFF would you mind giving this the once over to ensure we didn't miss any other Wiki examples and then we can merge.

Thank you!

[krowlandson]

This looks good to me @jonclyde. Thank you for identifying this and raising the PR to fix.

@matt-FFFFFF would you mind giving this the once over to ensure we didn't miss any other Wiki examples and then we can merge.

Thank you!

[matt-FFFFFF]

Thanks - I will take a look next week

[SteveBurkettNZ]

@matt-FFFFFF: The following lines should also be removed from the security_center settings section since they've been replaced by this new enable_defender_for_containers variable:

enable_defender_for_acr = true
enable_defender_for_kubernetes = true

[matt-FFFFFF]

/azp run unit

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).