Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to allow mixed types in object #256

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

krowlandson
Copy link
Contributor

Overview/Summary

This PR updates the object type for the template_file_variables input variable to allow specifying a map of objects containing different object types.

This change is necessary due to the way may(any) expects the object to be a map with values of the same type.

This PR fixes/adds/changes/removes

  1. Fixes Feature Request: Support full templating functionality of templatefile() in module #253, adding support for mixed object types in the template_file_variables input variable to enable full use of the template() function in Terraform
  2. Updates Wiki documentation to reflect this change

Breaking Changes

None

Testing Evidence

This change is as per the narrative in #253 and all automated tests will be used as evidence that this

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

@krowlandson krowlandson added the enhancement New feature or request label Jan 25, 2022
@krowlandson krowlandson requested a review from jtracey93 January 25, 2022 08:43
@krowlandson krowlandson self-assigned this Jan 25, 2022
@krowlandson
Copy link
Contributor Author

/azp run unit

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's make sure tests complete.

@krowlandson krowlandson merged commit c795826 into Azure:main Jan 25, 2022
@krowlandson krowlandson deleted the patch-253 branch January 25, 2022 12:36
@matt-FFFFFF
Copy link
Member

Will look tomorrow but speedy work @krowlandson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Support full templating functionality of templatefile() in module
3 participants