Update supported version, fix test failure #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rujche
commented
Jan 15, 2026
rujche
commented
- This PR update supported version, fix test failure
- Link to test pipeline: https://github.com/Azure/spring-cloud-azure-tools/actions/runs/21016587802
- Link to new created PR: Update Spring Boot and Spring Cloud versions for the Spring compatibility tests azure-sdk-for-java#47718
Netyyyy
reviewed
Jan 15, 2026
| Pattern.compile("(org.springframework.boot:spring-boot-dependencies;)([.\\-\\w]+)"); | ||
| static final Pattern SPRING_CLOUD_DEPENDENCIES_PATTERN = | ||
| Pattern.compile("(springboot3_org.springframework.cloud:spring-cloud-dependencies;)([.\\-\\w]+)"); | ||
| Pattern.compile("(org.springframework.cloud:spring-cloud-dependencies;)([.\\-\\w]+)"); |
Member
There was a problem hiding this comment.
should they be changed to springboot4_org ?
Member
Author
There was a problem hiding this comment.
No, change to spring-boot4_org will cause test failure. Here is the screenshot:
Use org will not have test failure:
It's just used to match string pattern:
Netyyyy
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.