Skip to content
This repository was archived by the owner on Jan 3, 2024. It is now read-only.

Using avocado diff algorithm instead of 'git fetch'#3

Merged
sergey-shandar merged 16 commits intomasterfrom
sergey/diff
Apr 19, 2019
Merged

Using avocado diff algorithm instead of 'git fetch'#3
sergey-shandar merged 16 commits intomasterfrom
sergey/diff

Conversation

@sergey-shandar
Copy link
Contributor

@sergey-shandar sergey-shandar commented Apr 18, 2019

Currently, breaking-changes and linter-diff tools do git fetch in CI. It causes a problem in AzureDevOps for a private repositories. The fix is replacing git fetch with Avocado diff/checkout algorithms.

Example Azure/azure-rest-api-specs#5691

Preproduction Azure pipeline with the changes https://dev.azure.com/azure-sdk/public/_build?definitionId=231

Related Avocado changes: Azure/avocado#18

Copy link

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline.

@sergey-shandar
Copy link
Contributor Author

@sergey-shandar
Copy link
Contributor Author

@veronicagg it's ready to review again.

Copy link

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments!

@sergey-shandar sergey-shandar merged commit c2c2891 into master Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants