Add alar2 to repair-script-library #13
Conversation
|
I see some a lot of non-code files, can we remove the release files? |
|
Let's revive ALAR 1 for existing users. |
|
Let's change the map.json file description so that we can tell users that ALAR 2 might take some time. |
…ded to inform the user that the build process takes about 2min to generate the alar2 binary
|
Hi Sungwoo, anything else I should improve or verify? |
| { | ||
| "id" : "linux-alar2", | ||
| "path" : "src/linux/linux-alar2.sh", | ||
| "description" : "alar2 allows to recover a failed VM. Various actions are available like: fstab, initrd and kernel. NOTE: use option --run-on-repair. See the docu for more details: https://github.com/Azure/repair-script-library/blob/master/src/linux/common/helpers/alar2/README.md. Please be aware that alar2 needs to be build on the recovery VM first. This takes about 2min. Please be patient." |
There was a problem hiding this comment.
- Remove "Please be patient."
- Please be aware that alar2 needs to be build on the recovery VM first
- what does this tell the user? run the command using --run-on-repair ? I think this should be removed or clarified.
- This takes about 2min
=> The script takes around 2 minutes to run.
|
Let's add a Readme for ALAR2 in the similar fashion as ALAR1 readme: https://github.com/Azure/repair-script-library/blob/alar2-test/src/linux/common/helpers/alar/README.md |
|
This "pull request" is not writable for me anymore. As branch alar2-test got created not as PR. It was a direct commit against the repository. |
|
@malachma can we close this PR? |
|
This PR can be closed. It got fixed by another PR |
This is new version of ALAR (alar2) it is intended to replace the current bash script based ALAR.
Any new development and bug-fixing will be performed on alar2 only.
There will be another PR again "Azure/azure-cli-extensions" for additional functionality as custom.py and repair_utils.py had to be extended/altered