-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed identity support for Azure Database for PostgreSQL #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just read the comments and think about if they need to be addressed or not
@@ -34,15 +35,14 @@ resource "azurerm_postgresql_flexible_server_database" "postresql_database" { | |||
server_id = module.postresql_database[0].database_server_id | |||
} | |||
|
|||
|
|||
# Demo purposes only: assign current user as admin to the created DB | |||
# Demo purposes only: assign current user as admin for the primary DB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you make it so that there is an 'azd env set' before they can use 'azd up' to reflect their awareness? As the user will probably NOT read the terraform?
end_ip_address = local.myip | ||
} | ||
|
||
# Demo purposes only: assign current user as admin for the dev DB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar as before
No description provided.