Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed identity support for Azure Database for PostgreSQL #215

Merged
merged 14 commits into from
Sep 20, 2024

Conversation

nickdala
Copy link
Member

No description provided.

Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just read the comments and think about if they need to be addressed or not

infra/shared/terraform/modules/postresql/main.tf Outdated Show resolved Hide resolved
@@ -34,15 +35,14 @@ resource "azurerm_postgresql_flexible_server_database" "postresql_database" {
server_id = module.postresql_database[0].database_server_id
}


# Demo purposes only: assign current user as admin to the created DB
# Demo purposes only: assign current user as admin for the primary DB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you make it so that there is an 'azd env set' before they can use 'azd up' to reflect their awareness? As the user will probably NOT read the terraform?

end_ip_address = local.myip
}

# Demo purposes only: assign current user as admin for the dev DB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar as before

@nickdala nickdala added this pull request to the merge queue Sep 20, 2024
Merged via the queue into Azure:main with commit 856caaa Sep 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants