Skip to content

fix: double canvas in react 18 strict mode #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yulinscottkang merged 2 commits into from
Jul 5, 2023
Merged

fix: double canvas in react 18 strict mode #162

yulinscottkang merged 2 commits into from
Jul 5, 2023

Conversation

@yulinscottkang
Copy link
Contributor

@yulinscottkang yulinscottkang commented Jul 3, 2023 •
edited
Loading

  • Fixes Doubled canvas and container #160

  • Root cause: useEffect is executed twice in development in React 18's strict mode to detect impure functions, causing atlas.Map to initialize twice.

  • Use useRef to ensure atlas.Map is initialized only once between component mount/unmount.

@yulinscottkang yulinscottkang added the v1.0 Version 1.0 label Jul 3, 2023
@yulinscottkang yulinscottkang merged commit e1d9f88 into Azure:version-1.0 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dubiety dubiety dubiety approved these changes

@ambientlight ambientlight Awaiting requested review from ambientlight

Assignees

No one assigned

Labels

v1.0 Version 1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yulinscottkang @dubiety