Skip to content

Fix #126 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmazuel merged 1 commit into from
Oct 15, 2018
Merged

Fix #126 #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions msrest/async_paging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ def __init__(self, *args, **kwargs):
"""
self._async_get_next = kwargs.get("async_command")
if not self._async_get_next:
_LOGGER.warning("Paging async iterator protocol is not available for %s",
self.__class__.__name__)
_LOGGER.debug("Paging async iterator protocol is not available for %s",
self.__class__.__name__)

async def async_get(self, url):
"""Get an arbitrary page.
Expand All @@ -53,13 +53,18 @@ async def async_get(self, url):
return await self.async_advance_page()

async def async_advance_page(self):
if not self._async_get_next:
raise NotImplementedError(
"The class %s does not support async paging at the moment.",
self.__class__.__name__
)
if self.next_link is None:
raise StopAsyncIteration("End of paging")
self._current_page_iter_index = 0
self._response = await self._async_get_next(self.next_link)
self._derserializer(self, self._response)
return self.current_page

async def __anext__(self):
"""Iterate through responses."""
# Storing the list iterator might work out better, but there's no
Expand Down