Browser xml #187
Merged
Browser xml #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Looks like some string comparisons are broken in tests that expect a |
RikkiGibson
force-pushed
the
browser-xml
branch
from
e621f32 to
55e4a3e
Compare
RikkiGibson
force-pushed
the
browser-xml
branch
from
55e4a3e to
97504cc
Compare
RikkiGibson
force-pushed
the
browser-xml
branch
from
97504cc to
f8b528b
Compare
Member
Author
|
Seems like we're all green on this now, so I'll just merge and if problems arise for XML users we can look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops isomorphic-xml2js and uses a simplified implementation with no runtime configuration supported. Saves 4 KB--now the overhead all users have to take on for XML support is just 2 KB.
Passes autorest.typescript tests.