Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Feature] persistent self hosted runner -> multiple runners on one persistent host #394

Open
AndreasAugustin opened this issue Jan 2, 2024 · 2 comments
Assignees
Labels
dev backlog Planned for future product enhancement New feature or request

Comments

@AndreasAugustin
Copy link
Contributor

Hi dear Azure/login action team,

maybe I am wrong, but I think there is an issue when you have multiple self hosted runners on one persistent host.

Following scenario:

  • Azure Linux VM (persistent) with one user
  • multiple runners registered (Github enterprise, but I am sure same should apply for Github.com) onto this one VM with same user (started service svc.sh)
  • using this github action for login

If I get it right, then the login will write authentication information (tokens,..) into ˜/.azure/.. Due to the fact that we have multiple runners on this one single host registered with the same user, one runner will steal the authentication information for the other jobs.
If this is the case, then it is highly dangerous because one runner will run with the credentials of another runner.

Maybe I did not fully get this right and the login is related to the runner and not the user.

If I am right, it would be nice to have the login context related to the runner not the user or at least add a howto/warning if using self hosted runners. Best would be to have one login context per workflow job.

@AndreasAugustin AndreasAugustin added the need-to-triage Requires investigation label Jan 2, 2024
@YanaXu YanaXu self-assigned this Jan 4, 2024
@YanaXu YanaXu removed the need-to-triage Requires investigation label Jan 4, 2024
@YanaXu
Copy link
Collaborator

YanaXu commented Jan 5, 2024

Hi @AndreasAugustin, you're right. Azure Login Action is not well-designed for self-hosted runners from the very beginning. Glad to see you‘re interested in mutil-runners in one host. You're correct about the user and login context. However, Azure Login Action relies on the underlying tools, which now do not support the use scenario.
We're working on this but it'll take a long time to make it happen as I can see.
Before that, let's mark this as a limitation of Azure Login Action.

@AndreasAugustin
Copy link
Contributor Author

Hi @YanaXu thanks for the verification.
Just added a short documentation add on #397 with the hope to help others ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev backlog Planned for future product enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants