Check aziot-edge
component instead of aziot-identity-service
#7382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
iotedge check
where IoTEdge uses the version of aziot-identity-service as aziot-edge version which results ineven if the latest version of IoT Edge daemon is installed on the machine.
Root cause:
The IoTEdge queries
https://github.com/Azure/azure-iotedge/blob/main/product-versions.json
for the latest info on each of the component. Currently, IoTEdge parses the wrong
component
instead of getting the version ofaziot-edge
, it getsaziot-identity-service
version. The aziot-identity-service version is then compared against theaziot-edge installed version if it is the latest version.
Manual test with custom build ID:
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines
Draft PRs
Draft
mode if it is:Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description