Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check aziot-edge component instead of aziot-identity-service #7382

Merged

Conversation

yophilav
Copy link
Contributor

@yophilav yophilav commented Oct 15, 2024

Bugfix iotedge check where IoTEdge uses the version of aziot-identity-service as aziot-edge version which results in

‼ aziot-edge package is up-to-date - Warning
Installed IoT Edge daemon has version 1.5.10 but 1.5.3 is the latest stable version available.

even if the latest version of IoT Edge daemon is installed on the machine.

Root cause:

The IoTEdge queries
https://github.com/Azure/azure-iotedge/blob/main/product-versions.json
for the latest info on each of the component. Currently, IoTEdge parses the wrong component instead of getting the version of aziot-edge, it gets aziot-identity-service version. The aziot-identity-service version is then compared against the
aziot-edge installed version if it is the latest version.

Manual test with custom build ID:
image

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • I have read the contribution guidelines.
  • Title of the pull request is clear and informative.
  • Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • local testing done.

Draft PRs

  • Open the PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.

Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description

@yophilav yophilav marked this pull request as ready for review October 15, 2024 20:35
@yophilav yophilav requested a review from nlcamp October 15, 2024 20:35
@yophilav yophilav merged commit ca5b8af into Azure:main Oct 17, 2024
17 checks passed
@damonbarry
Copy link
Member

Fixes #7353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants