Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add SKU type for the created cluster #152

Merged
merged 4 commits into from
Aug 6, 2024
Merged

ci: add SKU type for the created cluster #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a58f56
Update configure-helm-values.sh
helayoty Aug 6, 2024
56d54ba
Update Makefile
helayoty Aug 6, 2024
7983cea
Merge branch 'main' into helayoty-patch-1
helayoty Aug 6, 2024
677ab6d
Merge branch 'main' into helayoty-patch-1
helayoty Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ az-mkacr: az-mkrg ## Create test ACR
az acr login --name $(AZURE_ACR_NAME)

az-mkaks: az-mkacr ## Create test AKS cluster (with msi, oidc and workload identity enabled)
az aks create --name $(AZURE_CLUSTER_NAME) --resource-group $(AZURE_RESOURCE_GROUP) --attach-acr $(AZURE_ACR_NAME) \
az aks create --name $(AZURE_CLUSTER_NAME) --resource-group $(AZURE_RESOURCE_GROUP) --attach-acr $(AZURE_ACR_NAME) \
--kubernetes-version $(AKS_K8S_VERSION) --node-count 1 --generate-ssh-keys \
--enable-managed-identity --enable-workload-identity --enable-oidc-issuer -o none
--enable-managed-identity --enable-workload-identity --enable-oidc-issuer --node-vm-size Standard_D2s_v3 -o none
az aks get-credentials --name $(AZURE_CLUSTER_NAME) --resource-group $(AZURE_RESOURCE_GROUP)

az-rmrg: ## Destroy test ACR and AKS cluster by deleting the resource group (use with care!)
Expand Down
3 changes: 0 additions & 3 deletions hack/deploy/configure-helm-values.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ AZURE_RESOURCE_GROUP_MC=$(jq -r ".nodeResourceGroup" <<< "$AKS_JSON")
AZURE_TENANT_ID=$(az account show -o json |jq -r ".tenantId")
AZURE_SUBSCRIPTION_ID=$(az account show -o json |jq -r ".id")




GPU_PROVISIONER_USER_ASSIGNED_CLIENT_ID=$(az identity show --resource-group "${AZURE_RESOURCE_GROUP}" --name "${AZURE_GPU_PROVISIONER_USER_ASSIGNED_IDENTITY_NAME}" --query 'clientId' -otsv)

export CLUSTER_NAME AZURE_LOCATION AZURE_RESOURCE_GROUP_MC GPU_PROVISIONER_USER_ASSIGNED_CLIENT_ID AZURE_TENANT_ID AZURE_SUBSCRIPTION_ID
Expand Down
Loading