This repository was archived by the owner on Feb 12, 2025. It is now read-only.
all: remove unnecessary string([]byte) conversion in fmt.Sprintf yet %s #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed from Orijtech's continuous benchmarking product "Bencher" per https://dashboard.github.orijtech.com/benchmark/3245b8e4bbbd44a597480319aaa4b9fe that there is a bunch of code in the wild that invokes: fmt.Sprintf("%s", string([]byte(...))) yet the "%s" format specifier in fmt has a purpose: %s the uninterpreted bytes of the string or slice as well as using the "%c" format specifier which led to big improvements across every dimension: * CPU time reduction by 11+% (ns/op) * throughput improvement by 13+% (MBs/op) * allocations reduction by 45+% (B/op) * number of allocations reduction by 18+% (alloc/op) Also (*bytes.Buffer).String is invoked when "%q" or "%s" is passed in so no need to use it.
jhendrixMSFT
approved these changes
Dec 9, 2021
odeke-em
deleted the
remove-unnecessary-string-byteslice-in-fmtSprintf
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed from Orijtech's continuous benchmarking product "Bencher" per
https://dashboard.github.orijtech.com/benchmark/3245b8e4bbbd44a597480319aaa4b9fe
that there is a bunch of code in the wild that invokes:
yet the "%s" format specifier in fmt has a purpose:
as well as using the "%c" format specifier
which led to big improvements across every dimension:
Also (*bytes.Buffer).String is invoked when "%q" or "%s" is passed in so
no need to use it.