Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove net462 TFM #1125

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Remove net462 TFM #1125

merged 4 commits into from
Jul 11, 2024

Conversation

bachuv
Copy link
Collaborator

@bachuv bachuv commented Jul 3, 2024

Removed .NET Framework 4.6.2 TFM and upgraded DurableTask.Core version to 3.0.0.

@bachuv bachuv requested review from cgillum and davidmrdavid July 8, 2024 22:22
davidmrdavid
davidmrdavid requested changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's make sure the GitHub actions are running on all PRs, as this has not had the validation executed on it :)

nytian
nytian approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@nytian nytian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left a small question :)

src/DurableTask.ServiceBus/Tracking/AzureTableOrchestrationHistoryEventEntity.cs Show resolved Hide resolved
davidmrdavid
davidmrdavid approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve since the GitHub actions should run as soon as we try to merge to main. Let's open that PR asap

@bachuv bachuv merged commit 9714e8e into azure-storage-v12 Jul 11, 2024
1 check passed
@bachuv bachuv deleted the vabachu/remove-net462 branch July 11, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmrdavid davidmrdavid davidmrdavid approved these changes

@nytian nytian nytian approved these changes

@cgillum cgillum Awaiting requested review from cgillum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bachuv @cgillum @davidmrdavid @nytian