Removing unused DurableTask.Redis and DurableTask.SqlServer projects #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lum/remove-unused-projects
jviau
approved these changes
May 16, 2024
davidmrdavid
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the DurableTask.Redis and DurableTask.SqlServer projects from this local repository. This is part of an effort to reduce the amount of code we maintain in order to help improve hygiene and reduce requests for security patches.
Why are these projects being removed?
DurableTask.Rediswas an experimental project from many years ago and is missing many core features of DTFx. The DTFx maintainers have no plans to invest in this project further, so we're going to instead remove the project to reduce our code maintenance burden and to avoid any confusion about whether Redis is a supported backend for DTFx.DurableTask.SqlServerwas a community contribution from many years ago, but it only provides a tracking store implementation (it's not a full backend) and no nuget packages have been shipped. There are also no plans by the DTFx maintainers to invest further in this library.IMPORTANT NOTE: the
DurableTask.SqlServerproject that's being deleted from this repo is COMPLETELY UNRELATED to the official DurableTask.SqlServer project, which is used in production and is hosted in a separate GitHub repository. Removing this local unused DurableTask.SqlServer project reduces maintenance burden and avoids confusion. NO CHANGES WILL BE MADE TO THE OFFICIALDurableTask.SqlServerPROJECT, which continues to receive full support and periodic updates.