Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Calling][Refactor] More Call Options, End Call Confirm, Audio options ported to SwiftUI #877

Open
wants to merge 42 commits into
base: develop
Choose a base branch
from
Open

[Calling][Refactor] More Call Options, End Call Confirm, Audio options ported to SwiftUI #877

wants to merge 42 commits into from

Conversation

ahammer
Copy link
Member

@ahammer ahammer commented Jun 3, 2024 •
edited
Loading

Purpose

  • ...

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

Pull request checklist

This PR has considered:

  • Color Theming
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • View Data Injection
  • Demo App UI/UX update

How to Test

  • Open...
  • Click on...

What to Check

Before After
Screenshot or description before this change Screenshot or description with this change

Other Information

@ahammer ahammer changed the base branch from main to develop June 3, 2024 19:40
ahammer added 20 commits June 3, 2024 14:41
@ahammer
wiring up more call options
43f7082
@ahammer
clean up redundant actions
a0c3948
@ahammer
working towards redux for share modal sheet, as well as improve reducer
5f66161 
so that only one drawer can be enabled at a time.
@ahammer
share sheet now bound via redux
3ea0704
@ahammer
audio device popping up now
7683d6c
@ahammer
Merge branch 'develop' into feature/update_exit_confirmation_audio_an…
7a00f7d 
…d_more_options
@ahammer
add audio selection to setup screen
6d62f7c
@ahammer
drawer dismisses on audio device requested
5aade90
@ahammer
unified the view code for the drawers
52c43c4
@ahammer
clean up, introduce title view model
f02d600
@ahammer
clean up/organization, figma matching
4396095
@ahammer
added debouncing for the "show" options in the drawer
13cc28e
@ahammer
clean up, working towards tests
fd4b800
@ahammer
fixing tests
9b1ec05
@ahammer
tests compile
1f2802c
@ahammer
clean up tests, remove some obsolete tests after refactoring
80015f3
@ahammer
adding placeholder for test, fix unused self warning
80bf8c9
@ahammer
header violation
cf6083e
@ahammer
more unit tests around navigation reducer, fix up a11y identifiers for
17b27d1 
leave call confirm
@ahammer
Added more tests
02ce4b3
@ahammer ahammer marked this pull request as ready for review June 11, 2024 08:05
ahammer and others added 12 commits June 11, 2024 01:05
@ahammer
Merge branch 'develop' into feature/update_exit_confirmation_audio_an…
abe30e0 
…d_more_options
@ahammer
filtering on throttle wasn't working, fixed
1f6ac3e
@ahammer
add accessibility identifiers
55301ad
@ahammer
Merge branch 'feature/update_exit_confirmation_audio_and_more_options…
beabcbf 
…' of github.com:Azure/communication-ui-library-ios into feature/update_exit_confirmation_audio_and_more_options
@ahammer
make entire rows tappable
3999b52
@ahammer
reflect visibility state when dealing with drawers
fd1edf9
@ahammer
fix share sheet popping up issue
9c818e9
@ahammer
Merge branch 'develop' into feature/update_exit_confirmation_audio_an…
6d5cd32 
…d_more_options
@ahammer
Update Podfile.lock
7fe2e71
@ahammer
stabilize tests
1ec90dc
@ahammer
Merge branch 'feature/update_exit_confirmation_audio_and_more_options…
0f15533 
…' of github.com:Azure/communication-ui-library-ios into feature/update_exit_confirmation_audio_and_more_options
@ahammer
update throttling integration and keying to work again
dd011ab
@ahammer ahammer changed the title Feature/update exit confirmation audio and more options [Calling][Refactor] More Call Options, End Call Confirm, Audio options ported to SwiftUI Jun 17, 2024
@ShaunaSong
Copy link
Member

Audio Drawer cannot open properly on setup screen, please double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunaSong ShaunaSong ShaunaSong approved these changes

@pavelprystinka pavelprystinka Awaiting requested review from pavelprystinka pavelprystinka is a code owner automatically assigned from Azure/acs-ui-mobile-calling-reviewer-1

@jamchengms jamchengms Awaiting requested review from jamchengms jamchengms is a code owner automatically assigned from Azure/acs-ui-mobile-calling-reviewer-1

@iaulakh iaulakh Awaiting requested review from iaulakh iaulakh is a code owner automatically assigned from Azure/acs-ui-mobile-calling-reviewer-1

@Mohtasim Mohtasim Awaiting requested review from Mohtasim Mohtasim is a code owner automatically assigned from Azure/acs-ui-mobile-calling-reviewer-2

@waynemo waynemo Awaiting requested review from waynemo waynemo was automatically assigned from Azure/acs-ui-mobile-chat-reviewer-1

@palatter palatter Awaiting requested review from palatter palatter was automatically assigned from Azure/acs-ui-mobile-chat-reviewer-1

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 was automatically assigned from Azure/acs-ui-mobile-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft was automatically assigned from Azure/acs-ui-mobile-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms was automatically assigned from Azure/acs-ui-mobile-chat-reviewer-1

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac was automatically assigned from Azure/acs-ui-mobile-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai was automatically assigned from Azure/acs-ui-mobile-chat-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev was automatically assigned from Azure/acs-ui-mobile-chat-reviewer-2

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft was automatically assigned from Azure/acs-ui-mobile-chat-reviewer-2

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahammer @ShaunaSong