Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avm.res.automation.automation-account upgrade common types to latest and fix failing static validation #3662

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Oct 29, 2024

Description

Modules importing private endpoint UDT from AVM common types utility modules v0.1.0 or v0.2.0 are currently failing on static validation due to a recent Pester test verifying the correct parameter type description (Optional vs Required) and the private endpoint fqdn property being wrongly described as Required instead of Optional.

This pipeline fixes it for the avm.res.automation.automation-account module

Pipeline Reference

Pipeline
avm.res.automation.automation-account

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@eriqua eriqua self-assigned this Oct 29, 2024
@eriqua eriqua requested review from a team as code owners October 29, 2024 16:29
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Oct 29, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@eriqua eriqua added Type: Bug 🐛 Something isn't working Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Oct 29, 2024
@eriqua eriqua enabled auto-merge (squash) October 29, 2024 16:32
@eriqua eriqua merged commit bcf36c9 into Azure:main Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants