Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update the name of the aksAcrPull module from hard-coded to a variable. #3560

Merged
merged 14 commits into from
Oct 25, 2024

Conversation

Menghua1
Copy link
Member

@Menghua1 Menghua1 commented Oct 15, 2024

Description

Updated the name of the aksAcrPull module from hard-coded to a variable. To ensure that the resource names created for each deployment are unique.

Pipeline Reference

Pipeline
avm.ptn.azd.acr-container-app

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@jongio for notification.

@Menghua1 Menghua1 requested review from a team as code owners October 15, 2024 08:06
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 15, 2024
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Oct 15, 2024
@Menghua1
Copy link
Member Author

@AlexanderSehr Could you please review this PR?

@AlexanderSehr
Copy link
Contributor

@AlexanderSehr Could you please review this PR?

Hey @Menghua1,
now that the module is merged, @jongio, as the owner should ideally review the PRs (in alignment with the AVM specs). That's the idea behind 'scaling through the owners' 😉
If @jongio does not have any capacity, we maintainers can of course try to help out. 💪

@Menghua1
Copy link
Member Author

@jongio When updating PR#3976, it was found that the name of the module aksAcrPull in ptn/azd/acr-container-app was hardcoded during the migration process. When this module was created multiple times at the same time, a conflict error occurred. So I opened this PR, please review it, thank you.

@Menghua1 Menghua1 changed the title fix: Update aksAcrPull module name to be unique fix: Update the name of the aksAcrPull module from hard-coded to a variable. Oct 18, 2024
@v-xuto
Copy link
Member

v-xuto commented Oct 23, 2024

@jongio Could you hep review this PR? It blocks the progress of migration to avm.

@Menghua1
Copy link
Member Author

Menghua1 commented Oct 25, 2024

@AlexanderSehr Could you please review this PR? If there is no issue, please approve it.

@AlexanderSehr
Copy link
Contributor

@AlexanderSehr Could you please review this PR? If there is no issue, please approve it.

Hey @Menghua1, @jongio should have the permissions to merge the PR. I can merge it on his behalf - but usually would suggest against that as he may've had a reason I do not know. Will reach out

@v-xuto
Copy link
Member

v-xuto commented Oct 25, 2024

@jongio Could you help merge this PR? Thanks a lot.

@jongio jongio merged commit a3355f6 into Azure:main Oct 25, 2024
13 checks passed
jongio pushed a commit that referenced this pull request Oct 28, 2024
…in `ptn/azd/container-app-upsert` (#3647)

## Description
After
[PR3560](#3560) is
merged, update module `acr-container-app` version to the latest version
in ptn module `ptn/azd/container-app-upsert`.
<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes #123
Fixes #456
Closes #123
Closes #456
-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.ptn.azd.container-app-upsert](https://github.com/Menghua1/bicep-registry-modules/actions/workflows/avm.ptn.azd.container-app-upsert.yml/badge.svg?branch=update-module-version)](https://github.com/Menghua1/bicep-registry-modules/actions/workflows/avm.ptn.azd.container-app-upsert.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

@jongio and @AlexanderSehr for notification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants