fix: Update the name of the aksAcrPull module from hard-coded to a variable.
#3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Needs: Triage 🔍
avm-team-linter
bot
added
the
Needs: Module Owner 📣
microsoft-github-policy-service
bot
added
the
Type: AVM 🅰️ ✌️ Ⓜ️
|
@AlexanderSehr Could you please review this PR? |
Hey @Menghua1, |
Menghua1
changed the title
aksAcrPull module from hard-coded to a variable.
|
@jongio Could you hep review this PR? It blocks the progress of migration to avm. |
jongio
approved these changes
Oct 24, 2024
|
@AlexanderSehr Could you please review this PR? If there is no issue, please approve it. |
Hey @Menghua1, @jongio should have the permissions to merge the PR. I can merge it on his behalf - but usually would suggest against that as he may've had a reason I do not know. Will reach out |
|
@jongio Could you help merge this PR? Thanks a lot. |
11 tasks
jongio
pushed a commit
that referenced
this pull request
Oct 28, 2024
…in `ptn/azd/container-app-upsert` (#3647) ## Description After [PR3560](#3560) is merged, update module `acr-container-app` version to the latest version in ptn module `ptn/azd/container-app-upsert`. <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #123 Fixes #456 Closes #123 Closes #456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/Menghua1/bicep-registry-modules/actions/workflows/avm.ptn.azd.container-app-upsert.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> @jongio and @AlexanderSehr for notification.
](https://github.com/Menghua1/bicep-registry-modules/actions/workflows/avm.ptn.azd.container-app-upsert.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the name of the aksAcrPull module from hard-coded to a variable. To ensure that the resource names created for each deployment are unique.
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.@jongio for notification.