Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update API Version for Compute/SSH-key #3453

Merged
merged 70 commits into from
Oct 10, 2024

Conversation

ChrisSidebotham
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham commented Oct 8, 2024

Description

Closes #3095

Pipeline Reference

Pipeline
avm.res.compute.ssh-public-key

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

ChrisSidebotham and others added 30 commits October 12, 2023 14:59
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 8, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Oct 8, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@ChrisSidebotham ChrisSidebotham marked this pull request as ready for review October 9, 2024 16:15
@ChrisSidebotham ChrisSidebotham requested review from a team as code owners October 9, 2024 16:15
@ChrisSidebotham ChrisSidebotham self-assigned this Oct 9, 2024
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Oct 9, 2024
@ChrisSidebotham ChrisSidebotham removed the Needs: Triage 🔍 Maintainers need to triage still label Oct 9, 2024
@ChrisSidebotham
Copy link
Contributor Author

Needing core team due to me owning the module

@AlexanderSehr AlexanderSehr merged commit ac577d4 into Azure:main Oct 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Option to create ED25519 or RSA SSH keys to be added
2 participants