Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New module azure-stack-hci/cluster module #3364

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

feat: New module azure-stack-hci/cluster module #3364

wants to merge 53 commits into from

Conversation

mbrat2005
Copy link
Contributor

@mbrat2005 mbrat2005 commented Sep 25, 2024 •
edited
Loading

Description

Adds new Azure Stack HCI Cluster AVM module

Includes some helper modules for e2e testing placed here avm\utilities\e2e-template-assets\templates\azure-stack-hci, as I'll also be using them for other HCI resource modules (always needing to deploy an HCI cluster in Azure to test on). If this is not the right location for this sort of shared asset, please let me know...

Pipeline Reference

avm.res.azure-stack-hci.cluster

Pipeline

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

Maintainer checklist:

  • Microsoft.AzureStackHCI RP registered (in order to grant permissions before starting)
  • Service Principal created and granted Azure Resource Bridge Deployment role on the management group (deployment will create subscription-level permissions, but parallel deployments/failures may clean up the required role). Create a secret credential.
  • CI_arbDeploymentAppId
  • CI_arbDeploymentSPObjectId (from Enterprise Application)
  • CI_arbDeploymentServicePrincipalSecret
  • CI_hciResourceProviderObjectId (Get-AzADServicePrincipal -ApplicationId 1412d89f-b8a8-4111-b4fd-e82905cbd85d)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Sep 25, 2024
@mbrat2005 mbrat2005 mentioned this pull request Sep 25, 2024
Open
2 tasks
@mbrat2005 mbrat2005 marked this pull request as ready for review September 26, 2024 15:39
@mbrat2005 mbrat2005 requested review from a team as code owners September 26, 2024 15:39
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Sep 26, 2024
@eriqua eriqua changed the title feat: azure-stack-hci/cluster module feat: New module azure-stack-hci/cluster module Sep 27, 2024
@ReneHezser
Copy link
Contributor

ReneHezser commented Oct 4, 2024 •
edited
Loading

@mbrat2005
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

AlexanderSehr
AlexanderSehr reviewed Oct 9, 2024
View reviewed changes
.github/CODEOWNERS
@@ -33,6 +33,7 @@
/avm/res/app/managed-environment/ @Azure/avm-res-app-managedenvironment-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/app-configuration/configuration-store/ @Azure/avm-res-appconfiguration-configurationstore-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/automation/automation-account/ @Azure/avm-res-automation-automationaccount-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/azure-stack-hci/cluster/ @Azure/avm-res-azurestackhci-cluster-module-owners-bicep @Azure/avm-module-reviewers-bicep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The team may not exist or is not placed in the hierachy as expected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what I missed here:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mbrat2005, there's a chance that @matebarabas did not yet approve the parent-child relationship :) I'll doublecheck the values regardless.

AlexanderSehr
AlexanderSehr reviewed Oct 9, 2024
View reviewed changes
avm/utilities/e2e-template-assets/templates/azure-stack-hci/modules/azureStackHCIHost/README.md Outdated
@@ -0,0 +1,67 @@
# HCI Azure Host Deployment Bicep Module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come you have this readme here? Is this content you wanted to have in the module's README.md?
If so (in case you did not know), you can add a ## Notes section to it (and as many subheaders below it as you want) and add the content there. The readme generation will preserve that section and append it after the generation again to the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more because this code is reusable elsewhere (in labs, etc) and I wanted to document it for easier sharing. I could remove the readme of you prefer...

mbrat2005 and others added 13 commits October 24, 2024 07:40
@mbrat2005 @AlexanderSehr
Update avm/res/azure-stack-hci/cluster/deployment-settings/main.bicep
8faa6fc 
Co-authored-by: Alexander Sehr <[email protected]>
@mbrat2005 @AlexanderSehr
Update avm/res/azure-stack-hci/cluster/main.bicep
3150088 
Co-authored-by: Alexander Sehr <[email protected]>
@mbrat2005 @AlexanderSehr
Update avm/res/azure-stack-hci/cluster/deployment-settings/main.bicep
3cedad5 
Co-authored-by: Alexander Sehr <[email protected]>
@mbrat2005 @AlexanderSehr
Update avm/res/azure-stack-hci/cluster/main.bicep
316ab50 
Co-authored-by: Alexander Sehr <[email protected]>
@mbrat2005 @AlexanderSehr
Update avm/res/azure-stack-hci/cluster/main.bicep
27ec7fd 
Co-authored-by: Alexander Sehr <[email protected]>
@mbrat2005
UDT and variable redundancy fixes
48d81bc
@mbrat2005 @AlexanderSehr
Update avm/res/azure-stack-hci/cluster/main.bicep
d2970e5 
Co-authored-by: Alexander Sehr <[email protected]>
@mbrat2005 @AlexanderSehr
Update avm/res/azure-stack-hci/cluster/main.bicep
9923bbd 
Co-authored-by: Alexander Sehr <[email protected]>
@mbrat2005
setavm
8db1b80
@mbrat2005
remove host deployment from output
9b20060
@mbrat2005
moving reusable templates to module e2e
36b544d
@mbrat2005
Merge branch 'main' of https://github.com/Azure/bicep-registry-modules …
a112584 
…into mtb-azure-stack-hci-cluster
@mbrat2005
move template assets to test dir
9a3c31c
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Oct 28, 2024
AlexanderSehr
AlexanderSehr reviewed Oct 28, 2024
View reviewed changes
avm/res/azure-stack-hci/cluster/deployment-settings/main.bicep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small one, but the folder name must be singlular.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resource name is plural because it is a collection of settings--Microsoft.AzureStackHCI/clusters/deploymentSettings@2024-04-01

AlexanderSehr
AlexanderSehr reviewed Oct 28, 2024
View reviewed changes
avm/res/azure-stack-hci/cluster/tests/e2e/waf-aligned/main.test.bicep Outdated
@description('Optional. The name of the Azure Stack HCI cluster - this must be a valid Active Directory computer name and will be the name of your cluster in Azure.')
@maxLength(15)
@minLength(4)
param name string = 'hcicluster'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should ideally be a variable. The CI won't pass this value in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr left review comments

@eriqua eriqua eriqua left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@AlexanderSehr AlexanderSehr

@mbrat2005 mbrat2005

Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbrat2005 @ReneHezser @AlexanderSehr @eriqua