Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the creation of Microsoft.KeyVault/vaults/secrets in Sql Server Module - avm/res/sql/server #2859

Merged
merged 8 commits into from
Oct 12, 2024

Conversation

jianingwang123
Copy link
Contributor

Description

Fixes #2608

Set azure/login@v2 to use federated credential. (Due to some security policies, we are currently unable to use client secret for azure login. After completing all changes to this PR, we will restore the login method. This is currently only for testing the github pipeline.)

Pipeline Reference

Pipeline
avm.res.sql.server

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@jongio - for notification.

@jtracey93
Copy link
Contributor

@AlexanderSehr, @eriqua this PR changes the workflow for the module towards OIDC, but i am aware @eriqua has a PR due to sort this across all modules. Can you advise what we do here.

Also @jianingwang123 & @jongio as per my comment here is there any chance you or the team want to take ownership of this module?

@jongio
Copy link
Member

jongio commented Jul 26, 2024

Also @jianingwang123 & @jongio as per my comment here is there any chance you or the team want to take ownership of this module?

I'm pinging some people to see if we can find an owner.

@AlexanderSehr
Copy link
Contributor

Set azure/login@v2 to use federated credential

OIDC

Member

Correct. OIDC should not be part of a module PR given that it's a CI topic

@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Jul 29, 2024
@bryansan-msft
Copy link
Contributor

Im not sql server module owner anymore

@AlexanderSehr AlexanderSehr added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Aug 1, 2024
@eriqua
Copy link
Contributor

eriqua commented Sep 27, 2024

Hi @jianingwang123, after a few iterations, the bicep secrets export spec has finally been finalized. You can find the schema published here.

Would you be available to review it and leverage it to drive this PR to closure?
Please reach out if any doubts. Thanks!

@eriqua eriqua added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Class: Resource Module 📦 This is a resource module labels Sep 27, 2024
@ReneHezser
Copy link
Contributor

ReneHezser commented Oct 4, 2024

@jianingwang123
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Oct 4, 2024
@eriqua eriqua added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Oct 8, 2024
@jianingwang123
Copy link
Contributor Author

Hi @jianingwang123, after a few iterations, the bicep secrets export spec has finally been finalized. You can find the schema published here.

Would you be available to review it and leverage it to drive this PR to closure? Please reach out if any doubts. Thanks!

@AlexanderSehr and @eriqua, I have updated based on the bicep secrets export spec. Please help review.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Oct 11, 2024
@jianingwang123
Copy link
Contributor Author

@jianingwang123 We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

@ReneHezser Thank you for your guidance. I have updated branch and re-ran the Set-AVMModule utility.

@AlexanderSehr
Copy link
Contributor

AlexanderSehr commented Oct 11, 2024

Hey @peterbud and @emichellecarter, please give this PR a look when you get the chance :) Looks good to me. Thank you for the great work @jianingwang123 💪

Copy link
Contributor

@peterbud peterbud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexanderSehr AlexanderSehr merged commit 456d2bd into Azure:main Oct 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Sql Server Module should add the creation of Microsoft.KeyVault/vaults/secrets
9 participants