feat: Add the creation of Microsoft.KeyVault/vaults/secrets in Sql Server Module - avm/res/sql/server

[jianingwang123]

Description

Fixes #2608

Set azure/login@v2 to use federated credential. (Due to some security policies, we are currently unable to use client secret for azure login. After completing all changes to this PR, we will restore the login method. This is currently only for testing the github pipeline.)

Pipeline Reference

Pipeline

Type of Change

• Update to CI Environment or utilities (Non-module affecting changes)
• Azure Verified Module updates:
  • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
    • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
    • The bug was found by the module author, and no one has opened an issue to report it yet.
  • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
  • Breaking changes and I have bumped the MAJOR version in version.json.
  • Update to documentation

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• I have run Set-AVMModule locally to generate the supporting module files.
• My corresponding pipelines / checks run clean and green without any errors or warnings

@jongio - for notification.

[jtracey93]

@AlexanderSehr, @eriqua this PR changes the workflow for the module towards OIDC, but i am aware @eriqua has a PR due to sort this across all modules. Can you advise what we do here.

Also @jianingwang123 & @jongio as per my comment here is there any chance you or the team want to take ownership of this module?

[jongio]

Also @jianingwang123 & @jongio as per my comment here is there any chance you or the team want to take ownership of this module?

I'm pinging some people to see if we can find an owner.

[AlexanderSehr]

Set azure/login@v2 to use federated credential

OIDC

Member

Correct. OIDC should not be part of a module PR given that it's a CI topic

[bryansan-msft]

Im not sql server module owner anymore

[eriqua]

Hi @jianingwang123, after a few iterations, the bicep secrets export spec has finally been finalized. You can find the schema published here.

Would you be available to review it and leverage it to drive this PR to closure?
Please reach out if any doubts. Thanks!

[ReneHezser]

@jianingwang123
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

[jianingwang123]

Hi @jianingwang123, after a few iterations, the bicep secrets export spec has finally been finalized. You can find the schema published here.

Would you be available to review it and leverage it to drive this PR to closure? Please reach out if any doubts. Thanks!

@AlexanderSehr and @eriqua, I have updated based on the bicep secrets export spec. Please help review.

[jianingwang123]

@jianingwang123 We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

@ReneHezser Thank you for your guidance. I have updated branch and re-ran the Set-AVMModule utility.

[AlexanderSehr]

Hey @peterbud and @emichellecarter, please give this PR a look when you get the chance :) Looks good to me. Thank you for the great work @jianingwang123 💪

[peterbud]

Thanks!