Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Pull Request Template for AVM Module #1001

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

ChrisSidebotham
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham commented Feb 13, 2024

Description

Pipeline Reference

Update to the Pull Request Template to direct changes to Azure Verified Modules

Pipeline
N/A

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Feb 13, 2024
@ChrisSidebotham ChrisSidebotham marked this pull request as ready for review February 13, 2024 12:53
@ChrisSidebotham ChrisSidebotham requested review from a team as code owners February 13, 2024 12:53
@ChrisSidebotham
Copy link
Contributor Author

@eriqua @AlexanderSehr @jtracey93 - Topic for discussion, blended this from current template in CARML and AVM

AlexanderSehr
AlexanderSehr previously approved these changes Feb 17, 2024
@AlexanderSehr
Copy link
Contributor

Would be happy to approve this sooner than later and improve if need be

eriqua
eriqua previously approved these changes Feb 17, 2024
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua
Copy link
Contributor

eriqua commented Feb 17, 2024

Would be happy to approve this sooner than later and improve if need be

Agree, just requires Prettier fix to be merged

@eriqua eriqua closed this Feb 17, 2024
@eriqua eriqua reopened this Feb 17, 2024
@ChrisSidebotham ChrisSidebotham self-assigned this Feb 19, 2024
@ChrisSidebotham ChrisSidebotham added Type: Hygiene 🧹 things related to testing, issue triage etc. and removed Needs: Triage 🔍 Maintainers need to triage still labels Feb 19, 2024
@ChrisSidebotham
Copy link
Contributor Author

Waiting for prettier to work locally...

@ChrisSidebotham ChrisSidebotham merged commit dc80cbc into main Feb 20, 2024
11 checks passed
@ChrisSidebotham ChrisSidebotham deleted the csidebotham/PR-Update branch February 20, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Hygiene 🧹 things related to testing, issue triage etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants