Skip to content

Commit

Permalink
fix: Forwarding Ruleset property change from string to int (#3494)
Browse files Browse the repository at this point in the history
## Description

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes #123
Fixes #456
Closes #123
Closes #456
-->

Closes #3347 

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.network.dns-forwarding-ruleset](https://github.com/ChrisSidebotham/bicep-registry-modules/actions/workflows/avm.res.network.dns-forwarding-ruleset.yml/badge.svg?branch=dnsfrs-int-fix&event=workflow_dispatch)](https://github.com/ChrisSidebotham/bicep-registry-modules/actions/workflows/avm.res.network.dns-forwarding-ruleset.yml)|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [x] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
  • Loading branch information
ChrisSidebotham authored Oct 9, 2024
1 parent 13e77ed commit 2f08e57
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 19 deletions.
10 changes: 5 additions & 5 deletions avm/res/network/dns-forwarding-ruleset/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ module dnsForwardingRuleset 'br/public:avm/res/network/dns-forwarding-ruleset:<v
targetDnsServers: [
{
ipAddress: '192.168.0.1'
port: '53'
port: 53
}
]
}
Expand Down Expand Up @@ -209,7 +209,7 @@ module dnsForwardingRuleset 'br/public:avm/res/network/dns-forwarding-ruleset:<v
"targetDnsServers": [
{
"ipAddress": "192.168.0.1",
"port": "53"
"port": 53
}
]
}
Expand Down Expand Up @@ -288,7 +288,7 @@ param forwardingRules = [
targetDnsServers: [
{
ipAddress: '192.168.0.1'
port: '53'
port: 53
}
]
}
Expand Down Expand Up @@ -530,7 +530,7 @@ The target DNS servers to forward to.
| Parameter | Type | Description |
| :-- | :-- | :-- |
| [`ipAddress`](#parameter-forwardingrulestargetdnsserversipaddress) | string | The IP address of the target DNS server. |
| [`port`](#parameter-forwardingrulestargetdnsserversport) | string | The port of the target DNS server. |
| [`port`](#parameter-forwardingrulestargetdnsserversport) | int | The port of the target DNS server. |

### Parameter: `forwardingRules.targetDnsServers.ipAddress`

Expand All @@ -544,7 +544,7 @@ The IP address of the target DNS server.
The port of the target DNS server.

- Required: Yes
- Type: string
- Type: int

### Parameter: `forwardingRules.forwardingRuleState`

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "17239011184377594139"
"version": "0.30.23.60470",
"templateHash": "10407418001531703281"
},
"name": "Dns Forwarding Rulesets Forwarding Rules",
"description": "This template deploys Forwarding Rule in a Dns Forwarding Ruleset.",
Expand Down
2 changes: 1 addition & 1 deletion avm/res/network/dns-forwarding-ruleset/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -235,5 +235,5 @@ type targetDnsServers = {
ipAddress: string

@description('Required. The port of the target DNS server.')
port: string
port: int
}[]
14 changes: 7 additions & 7 deletions avm/res/network/dns-forwarding-ruleset/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "8260746772295919880"
"version": "0.30.23.60470",
"templateHash": "4145709731033849736"
},
"name": "Dns Forwarding Rulesets",
"description": "This template deploys an dns forwarding ruleset.",
Expand Down Expand Up @@ -190,7 +190,7 @@
}
},
"port": {
"type": "string",
"type": "int",
"metadata": {
"description": "Required. The port of the target DNS server."
}
Expand Down Expand Up @@ -394,8 +394,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "17239011184377594139"
"version": "0.30.23.60470",
"templateHash": "10407418001531703281"
},
"name": "Dns Forwarding Rulesets Forwarding Rules",
"description": "This template deploys Forwarding Rule in a Dns Forwarding Ruleset.",
Expand Down Expand Up @@ -522,8 +522,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "14775682641579876025"
"version": "0.30.23.60470",
"templateHash": "7319659019579418232"
},
"name": "Dns Forwarding Rulesets Virtual Network Links",
"description": "This template deploys Virtual Network Link in a Dns Forwarding Ruleset.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ module testDeployment '../../../main.bicep' = [
targetDnsServers: [
{
ipAddress: '192.168.0.1'
port: '53'
port: 53
}
]
}
Expand Down
2 changes: 1 addition & 1 deletion avm/res/network/dns-forwarding-ruleset/version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.4",
"version": "0.5",
"pathFilters": [
"./main.json"
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "14775682641579876025"
"version": "0.30.23.60470",
"templateHash": "7319659019579418232"
},
"name": "Dns Forwarding Rulesets Virtual Network Links",
"description": "This template deploys Virtual Network Link in a Dns Forwarding Ruleset.",
Expand Down

0 comments on commit 2f08e57

Please sign in to comment.