Fixes for Azs.Compute.Admin powershell module #127
Conversation
travist13
force-pushed
the
user/travist/fixpsmodule
branch
from
b6dbcea to
f5e556d
Compare
travist13
force-pushed
the
user/travist/fixpsmodule
branch
from
f5e556d to
592d7ca
Compare
src/Azs.Compute.Admin/docs/Disable-AzsTenantSubscriptionFeature.md
Outdated
Show resolved
Hide resolved
src/Azs.Compute.Admin/docs/Disable-AzsTenantSubscriptionFeature.md
Outdated
Show resolved
Hide resolved
src/Azs.Compute.Admin/docs/Enable-AzsTenantSubscriptionFeature.md
Outdated
Show resolved
Hide resolved
src/Azs.Compute.Admin/docs/Enable-AzsTenantSubscriptionFeature.md
Outdated
Show resolved
Hide resolved
bganapa
left a comment
bganapa
left a comment
There was a problem hiding this comment.
Thanks for the PR and working through the issues to improve the docs.
I have added fewcomments
travist13
left a comment
travist13
left a comment
There was a problem hiding this comment.
Updated per PR comments. I left 3 unresolved comments but responded to them.
|
@travist13 there are conflicts as my PR is already merged in to dev. Can you pls resolve, for the Test json files, you could simply take your changes and ignore whatever is committed in dev branch as you have rerecorded them |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 127 in repo Azure/azurestack-powershell |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
src/Azs.Compute.Admin/examples/Enable-AzsTenantSubscriptionFeature.md
Outdated
Show resolved
Hide resolved
src/Azs.Compute.Admin/examples/Update-AzsGlobalFeatureSetting.md
Outdated
Show resolved
Hide resolved
|
@FireDefend COuld you pls review this PR and approve? |
wmbt96
left a comment
wmbt96
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for removing the old features examples and updating the docs @travist13
|
@FireDefend Could you please take a look at my PR and let me know if any changes are necessary? Thanks! |
There was a problem hiding this comment.
src/Azs.Compute.Admin/docs/Update-AzsComputeGlobalFeatureSetting.md (line 87)
Add documentation on meaning of 3 string values:
Possible string values of GlobalFeatureSetting are Enabled, Disabled, and TenantSubscriptionLevel. Enabled/Disabled will override features that are enabled with tenant subscription ID. TenantSubscriptionLevel will defer feature enablement to per tenant subscription ID enablement.
|
/azp run |
|
Commenter does not have sufficient privileges for PR 127 in repo Azure/azurestack-powershell |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
5 participants
The powershell generation module has been broken for compute for 5 months. These are the fixes to get that module ready for 2108