Skip to content

Fixing\Updating AzsAdmin Compute powershell generation and tests. #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Fixing\Updating AzsAdmin Compute powershell generation and tests. #122

wants to merge 11 commits into from

Conversation

@travist13
Copy link
Contributor

@travist13 travist13 commented Jul 29, 2021 •
edited
Loading

Open API spec PR is updated and merged.
Dependent Open API Spec PR: Azure/azure-rest-api-specs#15059

This fixes many of the issues with the module generation and the tests. I also added a test for the new computeScaleUnit API.

@travist13 travist13 requested a review from a team as a code owner July 29, 2021 23:17
@travist13 travist13 requested review from TheOnlyWei and removed request for a team July 29, 2021 23:17
@travist13 travist13 changed the title [DNM] Fixing\Updating AzsAdmin Compute powershell generation and tests. Fixing\Updating AzsAdmin Compute powershell generation and tests. Aug 9, 2021
@TheOnlyWei
Copy link
Contributor

TheOnlyWei commented Aug 10, 2021

There are tests that have not been implemented, will these be implemented in the future?

@TheOnlyWei
Copy link
Contributor

TheOnlyWei commented Aug 10, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 10, 2021

Azure Pipelines successfully started running 3 pipeline(s).

@travist13
Copy link
Contributor Author

travist13 commented Aug 10, 2021

There are tests that have not been implemented, will these be implemented in the future?

The "Feature" tests are being implemented by Miguel. For the other NotImplemented tests I will create work items to implement those in a later effort. However, these other APIs are not changed recently and are being covered in our nightly team CI runs.

@TheOnlyWei
Copy link
Contributor

TheOnlyWei commented Aug 10, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 10, 2021

Azure Pipelines successfully started running 3 pipeline(s).

@travist13
Copy link
Contributor Author

travist13 commented Aug 11, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 11, 2021

Commenter does not have sufficient privileges for PR 122 in repo Azure/azurestack-powershell

@bganapa
Copy link
Member

bganapa commented Aug 11, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 11, 2021

Azure Pipelines successfully started running 3 pipeline(s).

@TheOnlyWei
Copy link
Contributor

TheOnlyWei commented Aug 11, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 11, 2021

Azure Pipelines successfully started running 3 pipeline(s).

TheOnlyWei
TheOnlyWei reviewed Aug 11, 2021
View reviewed changes
src/Azs.Compute.Admin/Azs.Compute.Admin.psd1
@@ -0,0 +1,25 @@
@{
Copy link
Contributor

@TheOnlyWei TheOnlyWei Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you need to check in this file, it should be generated by build-module.ps1 automatically.

src/Azs.Compute.Admin/utils/Unprotect-SecureString.ps1
@@ -0,0 +1,16 @@
#This script converts securestring to plaintext
Copy link
Contributor

@TheOnlyWei TheOnlyWei Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to commit this utils/ folder as these are files generated by autorest command and will overwrite this.

@bganapa
Copy link
Member

bganapa commented Aug 31, 2021

@travist13 closing this PR as your other PR is merged.

@bganapa bganapa closed this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheOnlyWei TheOnlyWei TheOnlyWei left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@travist13 @TheOnlyWei @bganapa