Exposing common scaling code to consume by SC v3#2937
Closed
Exposing common scaling code to consume by SC v3#2937
Conversation
alrod
force-pushed
the
alrod/sc-redesign1
branch
from
f3d2a9b to
91b3200
Compare
mathewc
reviewed
Dec 14, 2022
|
|
||
| namespace Microsoft.Azure.WebJobs.Host.Scale | ||
| { | ||
| public interface IScalerFactory |
Member
There was a problem hiding this comment.
Not sure this interface needs to be in the SDK. I don't see it used from either the SDK or the Host PR you linked to, so likely it's a SC specific thing and can just live there.
Member
Author
There was a problem hiding this comment.
All the extensions will implement the interface to use it from ScaleController. WebJobs SDK is common part for all the extensions.
mathewc
reviewed
Dec 14, 2022
mathewc
reviewed
Dec 14, 2022
mathewc
reviewed
Dec 14, 2022
mathewc
reviewed
Dec 14, 2022
mathewc
reviewed
Dec 14, 2022
mathewc
reviewed
Dec 14, 2022
mathewc
reviewed
Dec 14, 2022
mathewc
reviewed
Dec 14, 2022
This was referenced Jan 12, 2023
alrod
force-pushed
the
alrod/sc-redesign1
branch
from
12d2de1 to
705526e
Compare
Member
Author
|
closing in favor of #2954 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2938
Function host change:
Azure/azure-functions-host#8977