Check for cancellation after triggering function#852
Merged
Conversation
ealsur
reviewed
Jul 13, 2023
ealsur
requested changes
Aug 1, 2023
Member
ealsur
left a comment
ealsur
left a comment
There was a problem hiding this comment.
Please add tests for the scenario if possible
Contributor
Author
|
@microsoft-github-policy-service agree company="Smudge" |
Contributor
Author
|
@ealsur I've added an end-to-end test which covers this scenario. |
ealsur
approved these changes
Aug 17, 2023
Member
|
@brettsam Do you know how can we get the CI tests to run for external contributors that have no write permissions? |
Member
|
CI in this repo is not working for external forks, we'll try to test the fork manually |
Member
|
Manually running the test in the fork passes:
|
This was referenced Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #851 by throwing an exception if cancellation is requested, preventing automatic checkpointing from occurring.