Skip to content

[Cosmos DB] Adds more Change Feed logs#753

Merged
ealsur merged 10 commits intoAzure:devfrom
ealsur:users/ealsur/morelogs
Nov 19, 2021
Merged

[Cosmos DB] Adds more Change Feed logs#753
ealsur merged 10 commits intoAzure:devfrom
ealsur:users/ealsur/morelogs

Conversation

@ealsur
Copy link
Copy Markdown
Member

@ealsur ealsur commented Nov 15, 2021

This PR adds back the CosmosDBTriggerHealthMonitor leveraging the new Notification APIs to log:

  • When a lease is acquired
  • When a lease is released
  • When changes are delivered to a Function (before user code is processed)
  • When there are errors handling a lease, due to user unhandled exceptions or any Cosmos related failures

@ealsur ealsur requested a review from brettsam November 15, 2021 15:58
@ealsur ealsur self-assigned this Nov 15, 2021
Comment thread src/WebJobs.Extensions.CosmosDB/Trigger/CosmosDBTriggerHealthMonitor.cs Outdated
Copy link
Copy Markdown
Member

@brettsam brettsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions for the logging approach... otherwise looks good.

Comment thread src/WebJobs.Extensions.CosmosDB/Trigger/CosmosDBTriggerHealthMonitor.cs Outdated
Comment thread src/WebJobs.Extensions.CosmosDB/Trigger/CosmosDBTriggerHealthMonitor.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants