Skip to content

Cosmos DB - Add Support for AAD authentication#736

Merged
ealsur merged 9 commits intoAzure:devfrom
ealsur:users/ealsur/cosmosaad2
Aug 25, 2021
Merged

Cosmos DB - Add Support for AAD authentication#736
ealsur merged 9 commits intoAzure:devfrom
ealsur:users/ealsur/cosmosaad2

Conversation

@ealsur
Copy link
Copy Markdown
Member

@ealsur ealsur commented Aug 11, 2021

This PR expands the support for authentication to include AAD.

Users can define on the Cosmos DB Trigger or binding a Connection value that points to a configuration that either:

  • Is a string and represents a valid Cosmos DB Connection String
{
        "MyConnection": "<cosmos db connection string>"
}
  • Is a JSON node with valid AAD information:
{
	"MyConnection" : {
             "accountEndpoint": "https://myCosmosDBaccount.documents.azure.com:443/",
	     "clientId": "AAD client Id",
	     "tenantId": "AAD Tenant Id",
	     "clientSecret": "AAD secret"
       }
}

@ealsur ealsur requested a review from brettsam August 12, 2021 01:39
@brettsam
Copy link
Copy Markdown
Member

A couple of minor comments....

Comment thread src/WebJobs.Extensions.CosmosDB/WebJobsConfigurationExtensions.cs
Comment thread src/WebJobs.Extensions.CosmosDB/WebJobs.Extensions.CosmosDB.csproj Outdated
Comment thread src/WebJobs.Extensions.CosmosDB/Config/DefaultCosmosDBServiceFactory.cs Outdated
@pakrym
Copy link
Copy Markdown

pakrym commented Aug 25, 2021

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants