Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for file share #969

Open
wants to merge 92 commits into
base: main
Choose a base branch
from
Open

Added support for file share #969

wants to merge 92 commits into from

Conversation

gapra-msft
Copy link
Member

No description provided.

gapra-msft and others added 30 commits June 15, 2022 12:09
setup fileshare interface; listed empty methods of AzStorageConnection
Co-authored-by: Sourav Gupta <[email protected]>
@andyzhangx
Copy link
Contributor

As I know, azure file share only supports smb and nfs v4.1 protocols now, if this file share feature is supported by blobfuse2 mount, do you know whether managed identity would be supported by using blobfuse2 mount. @vibhansa-msft

@vibhansa-msft
Copy link
Member

This PR is only to add support for Azure Files using SAS and Key. OAuth support is not there in Go-SDK itself as of now and Blobfuse is using a pretty old Go-SDK. Once we move to Go 1.19 there will be effort to move to new Go-SDK as well in future and once we are there and by then if Files SDK adds OAuth support as well we will get it. However, this will take some time. Is there a need in AKS to have files support from Blobfuse end ? If so, I can put across this to our PM and we can think on this on priority.

@andyzhangx
Copy link
Contributor

This PR is only to add support for Azure Files using SAS and Key. OAuth support is not there in Go-SDK itself as of now and Blobfuse is using a pretty old Go-SDK. Once we move to Go 1.19 there will be effort to move to new Go-SDK as well in future and once we are there and by then if Files SDK adds OAuth support as well we will get it. However, this will take some time. Is there a need in AKS to have files support from Blobfuse end ? If so, I can put across this to our PM and we can think on this on priority.

@vikama-microsoft thanks for the clarification, I think it's not urgent, AKS team are exploring non key way(e.g. using kerberos auth) to mount azure file share, since this PR is still using the same password auth, then it's the same way as smb driver now.

@vibhansa-msft vibhansa-msft marked this pull request as ready for review May 10, 2023 12:45
@vibhansa-msft vibhansa-msft reopened this Aug 7, 2023
@vibhansa-msft vibhansa-msft removed this from the V2-2.3.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants